ambrose
/
fetch-compare
mirror of https://github.com/serverwentdown/fetch-compare.git
1
0
Fork 0
Code Releases Activity

fix: Cleanup after WebDriver errors

pull/1/head
Ambrose Chua 2021-09-10 00:54:26 +08:00
parent 30c22cff9f
commit dc3cc1f282
2 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/platform-browser.ts
View File

@ -50,8 +50,7 @@ export default class PlatformBrowser implements Platform {
this.silent = silent; this.silent = silent;
} }
async run(ctx: Context, file: string): Promise<Result> { async interact(ctx: Context, file: string, port: number): Promise<Result> {
const {child, port} = await start(this.driver, this.silent);
const client = await WebDriver.newSession({ const client = await WebDriver.newSession({
logLevel: 'warn', logLevel: 'warn',
port, port,
@ -75,7 +74,17 @@ export default class PlatformBrowser implements Platform {
)) as Result; )) as Result;
await client.deleteSession(); await client.deleteSession();
await stop(child);
return result; return result;
} }
async run(ctx: Context, file: string): Promise<Result> {
const {child, port} = await start(this.driver, this.silent);
try {
const result = await this.interact(ctx, file, port);
await stop(child);
return result;
} finally {
await stop(child);
}
}
} }